Theme btn visited/hover issue #104

Closed
jferguson opened this Issue Jul 19, 2012 · 5 comments

Projects

None yet

2 participants

@jferguson

I am noticing what seems to be an error in css generated by themeroller. This was a 1.1.0 imported/converted to 1.1.1.

In the theme 'c' css I see the following for theme 'a'

.ui-btn-up-a:visited,
.ui-btn-up-c a.ui-link-inherit {
color: #2F3E46 /{c-bup-color}/;
}

also

.ui-btn-hover-a:visited,
.ui-btn-hover-a:hover,
.ui-btn-hover-c a.ui-link-inherit {
color: #2F3E46 /{c-bhover-color}/;
}

removing all 'a' from those two blocks resolves the issue.

@jferguson

actually, realized the correct css should prob be:

.ui-btn-hover-c a:visited,
.ui-btn-hover-c a:hover

@tybenz

Someone just submitted an issue for this and it should be fixed now. Can you add a gist of the 1.1.0 theme file that you are trying to upgrade?

@jferguson

I am not sure it has anything to do with the upgrade. It happens anytime I edit a 1.1.1 theme. Can you confirm you would still like the original 1.1.0 css? or would you like the generated 1.1.1?

@jferguson

Looks like the original was a 1.0.1 file. (though it appears to have the same issue).

1.0.1
https://gist.github.com/3149332

1.1.1
https://gist.github.com/3149342

In 3149342 Take a look at lines 281-283, 299-301, 416, 433-434 etc, those are lines I am having probs with. (if all your themes buttons had the same color text, you wouldn't notice this issue)

@tybenz

Okay I found the problem. I had applied a fix but forgot to add it to the upgrade script.

Thanks again for the heads up. You can now import your bad 1.1.1 file and download again to check that TR is fixed.

Or you can just grab the result here: https://gist.github.com/7d1b5b0e018c0107338d. Let me know if you have any more issues

@tybenz tybenz closed this Jul 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment