Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with gradients? #149

Closed
jaspermdegroot opened this issue Nov 22, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@jaspermdegroot
Copy link
Member

commented Nov 22, 2013

The 1.4 default theme doesn't use gradients (background-image). In the ThemeRoller we still need them for <= 1.3. Question if we should remove gradients if someone upgrades from 1.3 to 1.4 and don't show gradient settings in the left panel, or should we keep them.

Maybe it's not even possible to keep them because background-image property/values (and the comments for the regex) are not in the default theme anymore.

@jaspermdegroot

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2013

We discussed this and background gradients will be ignored. You can still manually copy the background-image settings from your 1.3 custom theme.

@jaspermdegroot

This comment has been minimized.

Copy link
Member Author

commented Nov 22, 2013

Assigned to Hyunsook 👍

@jurgenfink

This comment has been minimized.

Copy link

commented Dec 3, 2013

swatch_a_1 4-white
swatch_b_1 4-dark
swatch_c_1 4-blue_light
swatch_d_1 4-blue_dark
swatch_e_1 4-oil_light
swatch_f_1 4-oil_dark
swatch_g_1 4-green_dark
swatch_g_1 4-green_light

@uGoMobi :

concerning: gradients (background-image) for new TR 1.4.0;

We did exactly what Jasper suggested:
We added manually the background-image and then only added at:

/* Active button */
...
background-image: none;
...

Works perfectly well for us and Active State would show correctly for the different Swatches.
Thus, we took the "gradient-feature" from TR <= 1.3. over to 1.4.0

Good job from all of you and thanks for sharing.
ThemeRoller rocks - it's a beautiful tool - we love it.
Saludos, Jürgen

@jaspermdegroot

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.