Importing of Valencia theme not working #74

Closed
alexturpin opened this Issue Feb 13, 2012 · 3 comments

Projects

None yet

3 participants

@alexturpin

When trying to import the Valencia theme from the official jQuery mobile repo, I first get a glimmer of the theme in the preview, then it reverts back to the "empty" gray theme. Upon trying to import for a second time, the theme stays in the preview, but I get an "Invalid theme file" error, and the theme isn't actually imported in the different controls on the left. There is also no way to change the previewed theme once an invalid theme has been imported.

Is this normal? The Valencia theme is in the official repo, but maybe it hasn't been updated to the latest structure for themes, and that would explain the importation troubles? Is there a work around?

Thanks.

@toddparker
Contributor

I think Valencia is a highly customized theme that probably can't be imported. I know if uses multi-stop gradients and other tricks that aren't part of TR so I think we probably just need to note that. We may need to eventually retire Valencia for this reason..it's not easily maintainable.

@tybenz
Contributor
tybenz commented Feb 14, 2012

As Todd said the Valencia theme is not compatible with TR. However, the fact that the default "empty" theme is not changeable after an "Invalid theme file" error is an issue that needs fixing.

@tybenz tybenz added a commit that referenced this issue Apr 16, 2012
@tybenz tybenz Fixed issue #74 d9ff410
@tybenz
Contributor
tybenz commented Apr 16, 2012

Again, Valencia theme is still incompatible with TR. However, if a user imports an invalid theme, it alerts them and undoes the import so they still have a theme that works with TR.

@tybenz tybenz closed this Apr 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment