Permalink
Browse files

encode conf params with encodeURIComponent so query strings can be us…

…ed in video urls
  • Loading branch information...
1 parent 560d84f commit 4e5d22ef306e26c65fbb93f025dceed2c4e2aabf @bradrobertson bradrobertson committed Sep 14, 2011
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/toolbox/toolbox.flashembed.js
@@ -191,7 +191,7 @@
for (var k in conf) {
if (conf[k]) {
var val = conf[k];
- vars += k +'='+ (/function|object/.test(typeof val) ? f.asString(val) : val) + '&';
+ vars += k +'='+ encodeURIComponent(/function|object/.test(typeof val) ? f.asString(val) : val) + '&';
}
}
vars = vars.slice(0, -1);

1 comment on commit 4e5d22e

This change broke backwards compatibility for previously encoded flashvars.
Prior to this change, I could pass this text as flashvars to my movie: SOLUTIONS DE GESTION DES RÉUNIONS D'TEST
thusly:

var flashvars = {someParam:"SOLUTIONS+DE+GESTION+DES+R%c3%89UNIONS+D%e2%80%99AFFAIRES+D%27TEST",...}

but now the encoding gets re-encoded

Please sign in to comment.