Join GitHub today
Notes to 1.2.4 release #153
Hi, there are some issues:
that was added by some of the contributors. never tested that. I'm sure there is some scenario/browser where that line is needed. I guess I need to further investigate this.
For me it's very strange to use space in value of name attribute, but of cause nothing is possible.
Another issue I want to propose is for validator script. It uses now "span" tag to wrap a error message. I believe it's very rare situation to display more than one message at the same line. So for a better markup did changes in my local copy to use "p" instead of "span". What do you think?
it's strange. should never use a space in attribute name or any other weird characters. but people are people.
the message container is specified in configuration. by default it's
inside this container we are adding individual error messages. they are wrapped inside a span element. i would say this is a solid system.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
ok. this is now changed. here is the patch:
I'm sure I'll get a lot of feedback that the error messages look different now. this is because span elements does not have any margin by default but p elements does.