Tabs and History don't work with jQuery 1.4.4 #261

Closed
BKnights opened this Issue Dec 2, 2010 · 4 comments

Projects

None yet

5 participants

@BKnights
BKnights commented Dec 2, 2010

I tried installing tabs.
Have used tabs before on the site but not with history. Tried enabling history as per example.
Nothing happened when clicked links except hash in url changed. When refreshed page correct pane appeared. Could control panes with api.
Removed history from tabs config and tabs worked but hashes didn't change.
replaced separate jQuery (1.4.4) and jQuery tools calls with full jQuery Tools load from cdn
tabs and history work.

@crh3675
crh3675 commented Jul 11, 2011

I have verified this same issue with the even with the patch (stefl@748f053) in place

@bradrobertson
Contributor

Try this commit. Tested with jquery 1.6.2 and it fixes history. Interested to see if it works for 1.4.4 also.

@alibby251
Contributor

Closing - assuming this is now working; please reopen if this is still an issue.

@alibby251 alibby251 closed this Sep 10, 2011
@wallrj
wallrj commented Sep 11, 2011

Yes this does seem to fix the issue in my application - using jquery 1.6.3

It may also fix #200.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment