Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

overlay with apple effect is not working as expected in firefox #310

Closed
snozwoz opened this Issue · 11 comments

4 participants

@snozwoz

Using overlay with apple effect in firefox does not work as expected.
There is no special test case or set up. The background image expands into the top left corner.
The issue is related to a bug in firefox.

http://bugs.jquery.com/ticket/7871

However you can work around the issue:
change lines 102, 103 to pos.left and pos.right instead of overlay.css("left"..
but this needs further testing to confirm.

@snozwoz

i have tried this:
in overlay/apple.html changing lines 465 to 469 to this resolves the issue

    img.animate({           
        top: pos.top, 
        left: pos.left, 
        width: oWidth}, conf.speed, function() {
@bradrobertson

I've just tried this with firefox 5 and jquery 1.6.2 and I see no problems. Can you confirm this?

@snozwoz

nice to have Brad Robertson doing some work on this library. I thought this project was dead, with the last release being a very long time ago.

I have had to implement several work around's over time, to deal with bugs. Can't remember them all, sorry, and have not logged them either as I thought there was no developer to fix them.

I have been using my fix documented here for a long time without any known issues.

@snozwoz snozwoz closed this
@snozwoz snozwoz reopened this
@bradrobertson

Ok I'll take another look. What version of jQuery are you using btw? As I said I wasn't able to reproduce this error with 1.6.2. I'm wondering if they've fixed some bugs on their end.

I'll see if this causes any issues with 1.6.2, and if it works for both, will apply the patch. Thanks for the info.

@snozwoz

this issue was only present in version 3.6 of firefox, which is still common place.
I am using latest jQuery now.

@neojiphre

hey guys can i have some help. i am using jquery.tools.min.js and i can't find where to put the code:
[code]img.animate({

top: pos.top,
left: pos.left,
width: oWidth}, conf.speed, function() {[/code]

however, i found this line:
[code]k.animate({top:f.css("top"),left:f.css("left"),width:j},g.speed,function(){f.css("zIndex",g.zIndex+1)[/code]
i changed "top" and "left" to "pos.top" and "pos.left" however it doesn't load my overlay.

@billreinhardt

In jquery.tools.min.js (v 1.2.6):

Find the code below:
k.animate({top:f.css("top"),left:f.css("left"),width:j},

And replace it with:
k.animate({top:b.top,left:b.left,width:j},

@snozwoz

the code change i gave was not for the min.js file. you are editing the min.js file, where things a bit different. follow billreinhardt advice if you want to edit the .min.js file. good luck with that, i dont edit the .min.js file i compile a new one after editing the non minified. but i am sure billreinhardt has given the correct instructions so go for it.

@snozwoz

it woudl be great if someone could actually commit this code change to git. i have been running the code change on our site since February without issue, and we have plenty of visitors that will have been testing it daily.

@bradrobertson

Sorry I somehow missed this in the 1.2.6 release. I'll be starting prioritization for 1.2.7 so I'll put this at the top of the list. Thanks again!

@bradrobertson

fix worked, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.