Fix for clicking on the next/prev month button hides calendar #497

Merged
merged 11 commits into from Mar 21, 2012

Projects

None yet

4 participants

@brewt
brewt commented Sep 8, 2011

If the next/prev month buttons are hidden via visibility: hidden and the user clicks on the area where the button is after it's been hidden, the click event's target ends up being the root node. The code that checks for this expects the event to be a child of the root node instead of the root node itself, so this patch just adds a check for this.

Hope I did this right :)

brewt and others added some commits Mar 14, 2011
@brewt brewt Fix for clicking on the next/prev month when it's been disabled via v…
…isibility: hidden closes the calendar - target is the root node instead of the button.
28b63c5
Jesse Allen Handling one or zero items with circular
Having one item with circular set to true resulted in a single item
cloned and scrolling, which is not a desirable condition. Having
zero items with circular set to true resulted in an error. By
enforcing a check more similar to the one performed when circular
is false, we are able to catch this condition.

Additionally, the prev and next buttons are set to disabled in the
case of one or zero items.
9abf5af
@bradrobertson bradrobertson Merge pull request #412 from jessecarl/master
Scrollable with one or zero items (and particularly with circular true)
e151df9
@bradrobertson bradrobertson Revert "Merge pull request #412 from jessecarl/master"
This reverts commit e151df9, reversing
changes made to 0046c59.
4b066f9
@bradrobertson bradrobertson update readme to instruct people to issue pull requests to dev 1ae09b9
@bradrobertson bradrobertson Merge branch 'master' of github.com:jquerytools/jquerytools 20a39e5
@ches
ches commented on 1ae09b9 Sep 3, 2011

It may be easier to set dev as the integration branch in the GitHub project admin section than to get everyone to remember to change the base for their pull requests. You can still use master as your "release" branch and dev as integration (in practice I'd say that's exactly the workflow you're following now anyhow =]).

Interesting, I didn't know about this. So setting the default branch in admin will prompt people to issue pull requests there instead of master?

ches replied Sep 3, 2011

If I recall correctly, yep! I was thinking it was referred to as 'Integration Branch' in the admin but it is 'Default' as you noted. It will also become what people see when they land at https://github.com/jquerytools/jquerytools too, and commit log shows that branch by default, etc.

jQuery Tools and others added some commits Sep 8, 2011
jQuery Tools Edited README.md via GitHub 94f4f7c
@brewt brewt Fix for clicking on the next/prev month button hides calendar.
If the next/prev month buttons are hidden via visibility: hidden and the user clicks on the area where the button is after it's been hidden, the click event's target ends up being the root node. The code that checks for this expects the event to be a child of the root node instead of the root node itself, so this patch just adds a check for this.
ebb5784
@brewt brewt Merge branch 'master' of github.com:jquerytools/jquerytools 662fe03
@brewt brewt Merge branch 'dev' of github.com:brewt/jquerytools into dev 66376c9
@brewt brewt Merge branch 'dev' of github.com:jquerytools/jquerytools into dev
Conflicts:
	README.md
d37be46
@duclet duclet merged commit 0fcad6f into jquerytools:dev Mar 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment