Dev: validator with single quotes for bracketed selectors #573

merged 1 commit into from Jan 19, 2012

2 participants


Dev: validator with single quotes for bracketed selectors


Hi, do you have an example where without the quotes this would break? I don't see a need for this as any value that could potentially break the code are not valid values for the "name" attribute.


Sure, any name with square brackets, which would create an array in PHP when you submitted it... eg:

<input name="data[Model][field]" value="123" />

Thanks. It has also come to my attention that the jQuery docs states that the quotes are required so we should probably go around and quote all the other places that are missing them. Thanks.


This fix should be expanded to more of the code base but for now, I think this is good to merge. I will merge it this friday unless someone objects.

@duclet duclet was assigned Jan 19, 2012
@duclet duclet merged commit 6dbd3ec into jquerytools:dev Jan 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment