Use quotes around attribute selectors for jQuery Tabs #626

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
@bbodien

bbodien commented Jan 19, 2012

As per #596

@ghost ghost assigned duclet Jan 19, 2012

+
+ self.seekTo(self.getIndex() +1, 0);
+
+ fire.trigger("onAddItemBefore", [item]);

This comment has been minimized.

Show comment Hide comment
@duclet

duclet Jan 19, 2012

Contributor

Please change the event name to "onBeforeAddItem" so that it matches the way the other events are named.

@duclet

duclet Jan 19, 2012

Contributor

Please change the event name to "onBeforeAddItem" so that it matches the way the other events are named.

This comment has been minimized.

Show comment Hide comment
@bbodien

bbodien Jan 27, 2012

Shouldn't it then be OnBeforeAddItemBefore? (Event triggered before we add an item before the other scrollable items)

@bbodien

bbodien Jan 27, 2012

Shouldn't it then be OnBeforeAddItemBefore? (Event triggered before we add an item before the other scrollable items)

This comment has been minimized.

Show comment Hide comment
@duclet

duclet Feb 1, 2012

Contributor

You know what, I must have a brain freeze or something. Totally mistook this for what it actually does. Ignore my comment regarding the name change. Though I will note that because this is a new feature, it probably won't be in the next release since I'm hoping for that release to be a bug fix release only.

@duclet

duclet Feb 1, 2012

Contributor

You know what, I must have a brain freeze or something. Totally mistook this for what it actually does. Ignore my comment regarding the name change. Though I will note that because this is a new feature, it probably won't be in the next release since I'm hoping for that release to be a bug fix release only.

@@ -186,7 +201,7 @@
});
// callbacks
- $.each(['onBeforeSeek', 'onSeek', 'onAddItem'], function(i, name) {
+ $.each(['onBeforeSeek', 'onSeek', 'onAddItem', 'onAddItemBefore'], function(i, name) {

This comment has been minimized.

Show comment Hide comment
@duclet

duclet Jan 19, 2012

Contributor

Same note as above.

@duclet

duclet Jan 19, 2012

Contributor

Same note as above.

@duclet

This comment has been minimized.

Show comment Hide comment
@duclet

duclet Feb 27, 2012

Contributor

Please follow guidelines here:
https://github.com/jquerytools/jquerytools/wiki/fixing-an-issue

Also, we'll have the fix for the tabs with #679.

Contributor

duclet commented Feb 27, 2012

Please follow guidelines here:
https://github.com/jquerytools/jquerytools/wiki/fixing-an-issue

Also, we'll have the fix for the tabs with #679.

@duclet duclet closed this Feb 27, 2012

@u982744

This comment has been minimized.

Show comment Hide comment
@u982744

u982744 Mar 6, 2013

So what happened to adding this feature in?

u982744 commented Mar 6, 2013

So what happened to adding this feature in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment