Fix for issue #710: flashembed.getVersion is broken since flash player v10.1 #818

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
1 participant
@sompylasar

#710

flashembed.getVersion() now returns three-element array of [major, minor, release] versions.
flashembed.isSupported() now supports fuzzy version comparison:

// Flash installed:
flashembed.getVersion() // => [11, 3, 300]
flashembed.isSupported() // => true
flashembed.isSupported([]) // => true
flashembed.isSupported([10]) // => true
flashembed.isSupported([10, 2]) // => true
flashembed.isSupported([11, 2]) // => true
flashembed.isSupported([11, 4]) // => false
flashembed.isSupported([11, 3, 200]) // => false
flashembed.isSupported([11, 3, 300]) // => true
flashembed.isSupported([12]) // => false

// Flash not installed:
flashembed.getVersion() // => [0, 0, 0]
flashembed.isSupported() // => false

External usages of flashembed.getVersion() and flashembed.isSupported() and derivatives (e.g. flowplayer options) must be updated to include the minor version component.

sompylasar added some commits Jul 25, 2012

flashembed: Fixed issue #710.
External usages of flashembed.getVersion() and flashembed.isSupported() and derivatives (e.g. flowplayer options) must be updated to include the minor version component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment