Fix invalid signature of outerHeight and outerWidth functions #851

Closed
wants to merge 3 commits into
from

5 participants

@SBoudrias

This is a re-pull of #849 to target the correct branch

Reading about outerheight in jQuery doc, it seems like the signature used before (eg outerHeight({margins:true})) have never been supported. As an object is a truthy value, I guess it just passed as a true boolean.

Although, as now outerHeight and outerWidth can be used as setter (v 1.8), jQuery now add type validation in these functions ( 1.8 vs 1.7.2 )

So, this fix should defenitly be added to the next version.

Related bugs: #839, #850

@akheron

+1. Without this, overlay is never centered correctly.

@alibby251

Thanks for the comment SBoudrias - I will check out both with this in mind.

@radubilei

Dateinput also needs this for calendar positioning

@SBoudrias

@alibby251 Just rebased by splitting commits for each component as you asked.

SBoudrias added some commits Aug 23, 2012
@SBoudrias SBoudrias Fix 'outerHeight' and 'outerWidth' function signature in overlay
Reading about [outerheight in jQuery doc](http://api.jquery.com/outerHeight/), it seems like the signature used before (eg `outerHeight({margins:true})`) have never been supported. As an object is a truthy value, I guess it just passed as a true boolean.

Although, as now [`outerHeight` and `outerWidth` can be used as setter](http://blog.jquery.com/2012/08/16/jquery-1-8-box-sizing-width-csswidth-and-outerwidth/), now jQuery add type validation in these functions ( [1.8](http://james.padolsey.com/jquery/#v=git&fn=jQuery.fn.outerHeight) vs [1.7.2](http://james.padolsey.com/jquery/#v=1.7.2&fn=jQuery.fn.outerHeight) )

So, this fix should defenitly should be added to next version.
0ea85b5
@SBoudrias SBoudrias Fix 'outerHeight' function signature in dateinput 841a537
@SBoudrias SBoudrias Fix 'outerWidth' function signature in overlay apple effect 522ce89
@mjl

Note that the dev branch has the fix in overlay.js but not in overlay.apple.js.

@SBoudrias

1 year in... Closing this. (and won't use jquery tools again...)

@SBoudrias SBoudrias closed this Sep 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment