Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix #855 Modal overlay forces a horizontal scrollbar in IE 9 #915

Open
wants to merge 7 commits into
from

Conversation

Projects
None yet
3 participants

vlazar commented Dec 12, 2012

The issue described here #855

The removed window.innerWidth returns window width, but it also includes vertical scrollbar width (if present). And it is for ie9+ only, but the comment incorrectly says it's for ie7+.

I've checked document.documentElement.clientWidth and it gives correct results in ie7, ie8, ie9.
The jQuery's $(window).width() also returns correct width, and can also be used, but I wanted the fix to be minimal.

vlazar added some commits Dec 12, 2012

@vlazar vlazar Fix #855 Modal overlay forces a horizontal scrollbar in IE 9 f03c98b
@vlazar vlazar Fix invalid signature for outerWidth/outerHeight calls. b524d5c
@vlazar vlazar Fix invalid signature for outerHeight call in dateinput. 8ed08f7
@vlazar vlazar Introduce frameSize option - number of visible items. Fixes #561 Scro…
…llable circular loop shows blank areas, should be seamless
c2674dd
@vlazar vlazar Rewrite overlay centering. For "fixed" overlay positioning it uses 50…
…% for left and top and margins in pixels (so now it stays centered on window resize). For "absolute" positioning it uses the old positioning in pixels.
7904221
@vlazar vlazar Fix scroll to conf.initialIndex for hidden scrollables. It's better f…
…ix for #87 - fixes initial position not only for circular scrollable with initialIndex = 0, but for non circular scrollable and any initialIndex too.
ac2d631
Contributor

alibby251 commented Jan 27, 2013

Hi vlazar,

Thanks for this - any chance you could please separate out these commits into separate instances? It will help - if one has an issue, then we would otherwise have to pull the whole lot. It would also help if you could please provide a JSfiddle showing the test case, and how your fixes help if possible?

vlazar commented Jan 28, 2013

Hi alibby251,

Sure, will do this as soon as I have time. Any interest in other commits, not related to #855 BTW?

I have the same issue. Have you ever consider open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment