Fixed memory leak in overlay library #976

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@spmason

spmason commented Mar 27, 2013

Overlays are added to the instances array, and never removed.  This means that DOM elements would leak over time

Added necessary cleanup to the overlays close method

Fixed memory leak in overlay library
Overlays are added to the instances array, and never removed.  This means that DOM elements would leak over time

Added necessary cleanup to the overlays `close` method
@alibby251

This comment has been minimized.

Show comment Hide comment
@alibby251

alibby251 Apr 25, 2013

Contributor

Hi spmason,

Thanks for this - could you please rebase your patch onto the dev branch, so I can commit it?

Contributor

alibby251 commented Apr 25, 2013

Hi spmason,

Thanks for this - could you please rebase your patch onto the dev branch, so I can commit it?

@alibby251 alibby251 closed this Apr 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment