Skip to content

Fix Unshrinkable null value equals And hashCode error#66

Merged
jlink merged 1 commit intojqwik-team:masterfrom
mhyeon-lee:fix-unshrinkable-null-value-error
Jul 24, 2019
Merged

Fix Unshrinkable null value equals And hashCode error#66
jlink merged 1 commit intojqwik-team:masterfrom
mhyeon-lee:fix-unshrinkable-null-value-error

Conversation

@mhyeon-lee
Copy link
Copy Markdown
Contributor

Overview

  • Unshrinkable null value got exception when call equals or hashCode method

Details

  • Fix equals and hashCode method to escape NPE.

I hereby agree to the terms of the jqwik Contributor Agreement.

@jlink
Copy link
Copy Markdown
Collaborator

jlink commented Jul 24, 2019

Thanks for the catch! Very valuable. I have two minor change requests. See there...

package net.jqwik.engine.properties.shrinking;

import net.jqwik.api.Arbitraries;
import net.jqwik.api.Example;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jqwik coding style is to use only wildcard imports, e.g. import net.jqwik.api.*

Comment thread engine/src/test/java/net/jqwik/engine/properties/shrinking/UnshrinkableTests.java Outdated
@jlink jlink merged commit 221d9bd into jqwik-team:master Jul 24, 2019
@jlink
Copy link
Copy Markdown
Collaborator

jlink commented Jul 24, 2019

Thanks again. Welcome to jqwik's list of contributors.

@jlink
Copy link
Copy Markdown
Collaborator

jlink commented Jul 24, 2019

Available in 1.2.0-SNAPSHOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants