New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding typo and NO_RESPONSE_PAGE parameter #2

Merged
merged 2 commits into from Aug 1, 2016

Conversation

Projects
None yet
2 participants
@vrobic
Contributor

vrobic commented Jul 29, 2016

Hi,

Two fixes here.

First, there was a typo in ResponseController for forwarding the response, between regular response and auto response.

Then, as stated in Atos/SIPS doc, the NO_RESPONSE_PAGE parameter was making the bank server use GET instead of POST for the response calls :

NO_RESPONSE_PAGE : Ce mot clé supprime l’affichage de la page de réponse à l’internaute. Il est ainsi directement reconnecté à la boutique du commerçant, sur l’URL paramétrée dans le champ normal_return_url ou cancel_return_url suivant que la transaction a été acceptée ou refusée.

L’utilisation de cette option modifie le protocole de la réponse renvoyée sur les URL paramétrées dans les champs normal_return_url et cancel_return_url. La réponse cryptée n’est plus envoyée en méthode POST, mais en méthode GET. La méthode GET ne permettant pas de véhiculer de grosses variables, tous les champs de la réponse ne sont pas renvoyés.

ResponseController expects a POST callback.

@jr-k jr-k merged commit 74226c1 into jr-k:master Aug 1, 2016

@jr-k

This comment has been minimized.

Show comment
Hide comment
@jr-k

jr-k Aug 1, 2016

Owner

Ok let's ship it

Owner

jr-k commented Aug 1, 2016

Ok let's ship it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment