Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decorating feature showing and updating offline snackbar #189

Merged
merged 5 commits into from Oct 12, 2019

Conversation

@jraska
Copy link
Owner

jraska commented Oct 12, 2019

  • This is example how to add feature to the whole app with decoration and using plugin based architecture.

  • Dependencies are added through NetworkStatusModule and instance of OnAppCreate. The app has a collection of these.

  • Functionality uses ActivityLifecycleCallbacks. If you use fragments, same solution will work with androidx.fragment.app.FragmentManager.FragmentLifecycleCallbacks

  • Demonstration of Easy to remove feature. The only thing to do would be removing Gradle module dependency from application module and remove NetworkStatusModule from AppComponent. App will compile and run without the feature

@jraska jraska force-pushed the decorating_feature branch from 5fd5814 to 6f7c024 Oct 12, 2019
@jraska jraska merged commit 633f1b2 into master Oct 12, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@jraska jraska deleted the decorating_feature branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.