Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `markdown-add-gfm-checkbox` and make it a final fallback for `markdown-do` #229

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@knu
Copy link
Contributor

knu commented Jul 27, 2017

I often just start writing a list item and notice it should have a checkbox, so I need something like this.

@jrblevin

This comment has been minimized.

Copy link
Owner

jrblevin commented Aug 2, 2017

Nice idea and thanks for sending a patch. I am slowing down adding features so that I can release v2.3, but I will get this in soon after that.

I appreciate that you added a test case as well—that really helps!

@knu

This comment has been minimized.

Copy link
Contributor Author

knu commented Oct 9, 2017

Could this be merged for 2.4? 😊

@jrblevin

This comment has been minimized.

Copy link
Owner

jrblevin commented Oct 10, 2017

Yes, thanks for the reminder. I committed it as 7772fc9 (I rebased it and also shortened the commit message so that it doesn't wrap). I made a couple of changes in subsequent commits for consistency with other similar commands: the new command is now named markdown-insert-gfm-checkbox and it is now at C-c C-s [ (along with other insertion commands under C-c C-s). Thanks again for the patch!

@jrblevin jrblevin closed this Oct 10, 2017

@knu knu deleted the knu:add-gfm-checkbox branch May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.