New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option markdown-gfm-uppsercase-checkbox #236

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@rnkn
Contributor

rnkn commented Aug 13, 2017

If non-nil, use [X] for completed checkboxes, [x] otherwise. Default nil.

Although I prefer the aesthetics of lowercase, GFM allows both, whereas Org only
allows uppercase. In the interest of cross-compatibility, this options allows
editing a checklist in either mode.

Add option markdown-gfm-uppsercase-checkbox
If non-nil, use [X] for completed checkboxes, [x] otherwise. Default nil.

Although I prefer the aesthetics of lowercase, GFM allows both, whereas Org only
allows uppercase. In the interest of cross-compatibility, this options allows
editing a checklist in either mode.
@rnkn

This comment has been minimized.

Show comment
Hide comment
@rnkn

rnkn Aug 13, 2017

Contributor

I'm not sure how to make tests sorry...

Contributor

rnkn commented Aug 13, 2017

I'm not sure how to make tests sorry...

@jrblevin

This comment has been minimized.

Show comment
Hide comment
@jrblevin

jrblevin Aug 14, 2017

Owner

Thanks! I committed this as a007a49 (where I fixed a typo in the commit message). I also added some documentation in 89d63a6.

Owner

jrblevin commented Aug 14, 2017

Thanks! I committed this as a007a49 (where I fixed a typo in the commit message). I also added some documentation in 89d63a6.

@jrblevin jrblevin closed this Aug 14, 2017

@rnkn

This comment has been minimized.

Show comment
Hide comment
@rnkn

rnkn Aug 16, 2017

Contributor

Awesome.

Can you help me out... so my repository history now diverges from yours... just to keep my side tidy if I wanna contribute something in the future, what I've done is pulled from yours, then force pushed back to mine... is this the right thing to do?

Contributor

rnkn commented Aug 16, 2017

Awesome.

Can you help me out... so my repository history now diverges from yours... just to keep my side tidy if I wanna contribute something in the future, what I've done is pulled from yours, then force pushed back to mine... is this the right thing to do?

@jrblevin

This comment has been minimized.

Show comment
Hide comment
@jrblevin

jrblevin Aug 16, 2017

Owner

That's exactly what I would have done, and your history looks the same as mine, so I think you should be good now.

In the future, another option is to make a new "feature branch" and issue the PR from that branch. Then if we happen to diverge you can just delete that feature branch and pull from master to get back in sync. It saves maybe one or two steps, but if you're comfortable occasionally doing a hard reset and force push it really doesn't matter.

Owner

jrblevin commented Aug 16, 2017

That's exactly what I would have done, and your history looks the same as mine, so I think you should be good now.

In the future, another option is to make a new "feature branch" and issue the PR from that branch. Then if we happen to diverge you can just delete that feature branch and pull from master to get back in sync. It saves maybe one or two steps, but if you're comfortable occasionally doing a hard reset and force push it really doesn't matter.

@rnkn

This comment has been minimized.

Show comment
Hide comment
@rnkn

rnkn Aug 16, 2017

Contributor

Cool, thanks.

Contributor

rnkn commented Aug 16, 2017

Cool, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment