Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noConflict to Almond #54

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented May 6, 2013

At Atlassian we have a plugin which is used in all of our products which is responsible for the management and installation of other plugins. This central plugin must work with a variety of host products which have different front-end architectures, i.e. some which use almond and others which don't.

To ensure this central plugin works nicely with all products it's best if it provides its own dependencies (including almond) to ensure it:

  • is not dependant on external products dependencies.
  • maintains its own set of module definitions without potentially clobbering the host product's modules.
  • works with multiple versions of the products irrespective of their front-end stack.

A way to do this is is to implement noConflict in Almond so the plugin mentioned above does not interfere with the product's copy (if it exists).

@ghost ghost closed this May 6, 2013
@ghost
Copy link
Author

ghost commented May 6, 2013

Closing until I've figured out the licensing / CLA requirements of this PR.

@jrburke
Copy link
Member

jrburke commented May 8, 2013

Just getting through my support notification backlogs now:

I do not have plans to support this in almond itself, however, the goal of these kinds of small AMD API providers is that there would be multiple ones for different needs. So I encourage you to just keep your fork going on its own. If you feel like doing that, please add a link to it on this wiki page so that others might find it and use it if it fits their needs:

https://github.com/jrburke/requirejs/wiki/AMD-API-Shims

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant