New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2gams shield schema #50

Merged
merged 19 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@auerj
Collaborator

auerj commented Sep 28, 2018

Ros2gams changes from the last sprint

auerj added some commits Sep 4, 2018

@auerj auerj requested review from dskyle and jredmondson as code owners Sep 28, 2018

@jredmondson

This comment has been minimized.

Owner

jredmondson commented Oct 1, 2018

@dskyle any issues?

@dskyle

This comment has been minimized.

Collaborator

dskyle commented Oct 1, 2018

So PCL is now a dependency if ROS support is enabled? Is it strongly necessary that this dependency be added? This dependency is not active if ROS support is inactive, right?

@auerj

This comment has been minimized.

Collaborator

auerj commented Oct 2, 2018

The new pointclouds are PCL based so we need pcl in ros2gams. This dependency is only active with ros support (see using_ros.mpb)

@dskyle

dskyle approved these changes Oct 2, 2018

@dskyle dskyle merged commit 4d4de85 into master Oct 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment