Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modman filters with chars following a '*' aren't parsed properly in move_files() #10

Open
jeffreyodum opened this issue Jan 27, 2014 · 0 comments

Comments

@jeffreyodum
Copy link

If a module contains a modman file containing filters like "*{something}", files that match that filter are not deployed in move_files().

The problem happens when the modman file’s filter expression ends with “{something}”, like “app/etc/modules/.xml”.

Line 337 of modgit is:

line=”${line/*/}” # remove * char

Which means the comparison on line 339 of:

if [[ "$file" =~ ^$1 ]]

will fail in these cases as it will evaluate to something like:

if [[ "app/etc/local.xml.phpunit" =~ "app/etc/modules/.xml" ]]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant