support for active job #111

Merged
merged 3 commits into from Oct 28, 2014

Conversation

Projects
None yet
3 participants
@katafrakt

Support for Rais 4.2 ActiveJob

@jrgifford

This comment has been minimized.

Show comment
Hide comment
@jrgifford

jrgifford Oct 3, 2014

Owner

Can you re-run bundle install? Travis coughed on that change.

Other than that, this looks amazing.

Owner

jrgifford commented Oct 3, 2014

Can you re-run bundle install? Travis coughed on that change.

Other than that, this looks amazing.

@ScotterC

This comment has been minimized.

Show comment
Hide comment
@ScotterC

ScotterC Oct 3, 2014

Collaborator

This is awesome. Thanks @katafrakt! I can't wait to switch entirely to ActiveJob so we only have to maintain and test one implementation

Collaborator

ScotterC commented Oct 3, 2014

This is awesome. Thanks @katafrakt! I can't wait to switch entirely to ActiveJob so we only have to maintain and test one implementation

@katafrakt

This comment has been minimized.

Show comment
Hide comment
@katafrakt

katafrakt Oct 4, 2014

Here it is. I hope this time Travis will accept this (I don't know much about how it works, as we use other CI tools).

I am still working on some more elaborate tests but right now it seems to be more difficult than I thought.

Here it is. I hope this time Travis will accept this (I don't know much about how it works, as we use other CI tools).

I am still working on some more elaborate tests but right now it seems to be more difficult than I thought.

@katafrakt

This comment has been minimized.

Show comment
Hide comment
@katafrakt

katafrakt Oct 4, 2014

Oh boy... Test::Unit. This is going to be hard...

However, I understand from #72 that Test::Unit is going to be removed in favor of RSpec. Is that right?

Oh boy... Test::Unit. This is going to be hard...

However, I understand from #72 that Test::Unit is going to be removed in favor of RSpec. Is that right?

@jrgifford

This comment has been minimized.

Show comment
Hide comment
@jrgifford

jrgifford Oct 4, 2014

Owner

@katafrakt Yes, that is correct. We would prefer any new stuff to be done in RSpec. Sorry for wasting your time there. :(

Owner

jrgifford commented Oct 4, 2014

@katafrakt Yes, that is correct. We would prefer any new stuff to be done in RSpec. Sorry for wasting your time there. :(

integration tests for active job
+ few corrections for running test within rails 4.2 env (deprecation warnings)
@katafrakt

This comment has been minimized.

Show comment
Hide comment
@katafrakt

katafrakt Oct 4, 2014

So, here are the specs.

Rails 4.2 requires minitest 5, which is not, and will never be, compatible with Test::Unit, so I used a very dirty way to overcome this (just skipping Test::Unit with brute force). Let me know if you have another idea how to handle it.

Unfortunately, it still fails under ruby 1.9.3 and rails 4.2, which are incompatible too.

So, here are the specs.

Rails 4.2 requires minitest 5, which is not, and will never be, compatible with Test::Unit, so I used a very dirty way to overcome this (just skipping Test::Unit with brute force). Let me know if you have another idea how to handle it.

Unfortunately, it still fails under ruby 1.9.3 and rails 4.2, which are incompatible too.

@katafrakt

This comment has been minimized.

Show comment
Hide comment
@katafrakt

katafrakt Oct 6, 2014

OK, Travis is green now ;)

OK, Travis is green now ;)

@ScotterC

This comment has been minimized.

Show comment
Hide comment
@ScotterC

ScotterC Oct 6, 2014

Collaborator

This is awesome @katafrakt 👍. I wish everyone PR'ed like this.
@jrgifford Let me know if you see anything otherwise this should be merged.

Collaborator

ScotterC commented Oct 6, 2014

This is awesome @katafrakt 👍. I wish everyone PR'ed like this.
@jrgifford Let me know if you see anything otherwise this should be merged.

@katafrakt

This comment has been minimized.

Show comment
Hide comment
@katafrakt

katafrakt Oct 20, 2014

Sooo... Any news?

Sooo... Any news?

ScotterC added a commit that referenced this pull request Oct 28, 2014

@ScotterC ScotterC merged commit 6d70ab0 into jrgifford:master Oct 28, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@katafrakt katafrakt deleted the katafrakt:active_job branch Oct 29, 2014

@katafrakt katafrakt restored the katafrakt:active_job branch Nov 26, 2014

@katafrakt katafrakt deleted the katafrakt:active_job branch Oct 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment