New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Resque, Sidekiq and DelayedJob adapters. #178

Merged
merged 1 commit into from May 3, 2016

Conversation

Projects
None yet
2 participants
@morgoth
Collaborator

morgoth commented Apr 29, 2016

For better maintenance of gem delayed_paperclip will only support
ActiveJob adapter which is available by default since Rails 4.2.
It's possible to use any of this 3 background job adapters through AJ.

@ScotterC Please take a look if we are on the same page.
In version 3.0:

  • remove all adapters except AJ
  • bump required Ruby version to 2.0
  • bump required Rails version to 4.2

If that's the plan, can you please merge it and release 2.10.0 with this deprecation warnings?

Deprecate Resque, Sidekiq and DelayedJob adapters.
For better maintenance of gem `delayed_paperclip` will only support
`ActiveJob` adapter which is available by default since Rails 4.2.
It's possible to use any of this 3 background job adapters through AJ.

@morgoth morgoth referenced this pull request Apr 29, 2016

Closed

Improve maintenance of gem #173

@@ -8,6 +9,11 @@ class DelayedJob < Struct.new(:instance_klass, :instance_id, :attachment_name)
if Gem.loaded_specs['delayed_job'].version >= Gem::Version.new("2.1.0")
def self.enqueue_delayed_paperclip(instance_klass, instance_id, attachment_name)
ActiveSupport::Deprecation.warn(<<-MESSAGE)

This comment has been minimized.

@ScotterC

ScotterC Apr 29, 2016

Collaborator

@morgoth did you have a chance to double check whether this shows up in the main server log and not just background job logs?

@ScotterC

ScotterC Apr 29, 2016

Collaborator

@morgoth did you have a chance to double check whether this shows up in the main server log and not just background job logs?

This comment has been minimized.

@morgoth

morgoth Apr 30, 2016

Collaborator

Yes, it shows on server logs, as it's done when enqueuing, not performing.

@morgoth

morgoth Apr 30, 2016

Collaborator

Yes, it shows on server logs, as it's done when enqueuing, not performing.

This comment has been minimized.

@ScotterC

ScotterC May 2, 2016

Collaborator

👍

@ScotterC

ScotterC May 2, 2016

Collaborator

👍

@@ -27,6 +27,15 @@
dummy.save!
Delayed::Job.last.payload_object.perform
end
it "is deprecated" do

This comment has been minimized.

@ScotterC

ScotterC Apr 29, 2016

Collaborator

thanks for the test

@ScotterC

ScotterC Apr 29, 2016

Collaborator

thanks for the test

@ScotterC ScotterC referenced this pull request Apr 29, 2016

Closed

Version 3.0 #179

6 of 6 tasks complete
@ScotterC

This comment has been minimized.

Show comment
Hide comment
@ScotterC

ScotterC Apr 29, 2016

Collaborator

@morgoth looks good and I like the plan. Made a Version 3.0 issue to help discussion #179

Collaborator

ScotterC commented Apr 29, 2016

@morgoth looks good and I like the plan. Made a Version 3.0 issue to help discussion #179

@morgoth

This comment has been minimized.

Show comment
Hide comment
@morgoth

morgoth May 3, 2016

Collaborator

If there are no blockers, please merge and release 2.10

Collaborator

morgoth commented May 3, 2016

If there are no blockers, please merge and release 2.10

@ScotterC ScotterC merged commit 458e101 into master May 3, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ScotterC ScotterC deleted the deprecate-adapters branch May 3, 2016

@ScotterC

This comment has been minimized.

Show comment
Hide comment
@ScotterC

ScotterC May 3, 2016

Collaborator

@morgoth 2.10 pushed into the wild

Collaborator

ScotterC commented May 3, 2016

@morgoth 2.10 pushed into the wild

morygonzalez pushed a commit to morygonzalez/delayed_paperclip that referenced this pull request Sep 28, 2016

Merge pull request #178 from jrgifford/deprecate-adapters
Deprecate Resque, Sidekiq and DelayedJob adapters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment