fix for DelayedJob version fix #53

[maintux]

No description provided.

[ScotterC]

Mind updating the gemfile locks and committing them? Travis failed on them.

[maintux]

Hi, Travis seems to fail again.. but I can't figure out the cause...

[ScotterC]

Ahh I see it. In your gemfile.locks (multiple of them) remove your path from remote: and change it to simply .. Push that up and you should be good.

[maintux]

mmm doesn't work....

[ScotterC]

Do the tests pass locally?

[maintux]

of course yes:

BUNDLE_GEMFILE=gemfiles/rails3_1.gemfile bundle exec rake test
/home/maintux/.rvm/rubies/ree-1.8.7-2012.02/bin/ruby -I"lib:lib:test" -I"/home/maintux/.rvm/gems/ree-1.8.7-2012.02/gems/rake-0.9.2.2/lib" "/home/maintux/.rvm/gems/ree-1.8.7-2012.02/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" 
Loaded suite /home/maintux/.rvm/gems/ree-1.8.7-2012.02/gems/rake-0.9.2.2/lib/rake/rake_test_loader
Started
..................................
Finished in 0.857633 seconds.

34 tests, 72 assertions, 0 failures, 0 errors

BUNDLE_GEMFILE=gemfiles/rails3.gemfile bundle exec rake test
/home/maintux/.rvm/rubies/ree-1.8.7-2012.02/bin/ruby -I"lib:lib:test" -I"/home/maintux/.rvm/gems/ree-1.8.7-2012.02/gems/rake-0.9.2.2/lib" "/home/maintux/.rvm/gems/ree-1.8.7-2012.02/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" 
Loaded suite /home/maintux/.rvm/gems/ree-1.8.7-2012.02/gems/rake-0.9.2.2/lib/rake/rake_test_loader
Started
..................................
Finished in 1.013699 seconds.

34 tests, 72 assertions, 0 failures, 0 errors

BUNDLE_GEMFILE=gemfiles/rails2.gemfile bundle exec rake test
/home/maintux/.rvm/rubies/ree-1.8.7-2012.02/bin/ruby -I"lib:lib:test" -I"/home/maintux/.rvm/gems/ree-1.8.7-2012.02/gems/rake-0.9.2.2/lib" "/home/maintux/.rvm/gems/ree-1.8.7-2012.02/gems/rake-0.9.2.2/lib/rake/rake_test_loader.rb" "test/**/*_test.rb" 
Loaded suite /home/maintux/.rvm/gems/ree-1.8.7-2012.02/gems/rake-0.9.2.2/lib/rake/rake_test_loader
Started
[Worker(host:zeus pid:29353)] DelayedPaperclip::Jobs::DelayedJob completed after 0.0040
..[Worker(host:zeus pid:29353)] DelayedPaperclip::Jobs::DelayedJob completed after 0.0047
.....[Worker(host:zeus pid:29353)] DelayedPaperclip::Jobs::DelayedJob completed after 0.0044
[Worker(host:zeus pid:29353)] DelayedPaperclip::Jobs::DelayedJob completed after 0.0455
...[Worker(host:zeus pid:29353)] DelayedPaperclip::Jobs::DelayedJob completed after 0.0041
.[Worker(host:zeus pid:29353)] DelayedPaperclip::Jobs::DelayedJob failed with StandardError: oops - 0 failed attempts
.....[Worker(host:zeus pid:29353)] DelayedPaperclip::Jobs::DelayedJob completed after 0.0044
..................
Finished in 0.81356 seconds.

34 tests, 72 assertions, 0 failures, 0 errors

[ScotterC]

I think I've figured this out a bit better. The rails2 branch isn't in development and actually isn't supposed to be for rails 2 at all. The master branch is tested against rails 2 with the appraisal gem. Please test your code against master when you have a chance and submit a PR.

[ScotterC]

@maintux I was wrong. The rails2 branch is actively for rails2. Just updated it to have a tighter focus. However, I can't get the tests to run on it locally even without your commits. Did you have any trouble getting them working with the appraisal gem, i.e. using the rake task.

[maintux]

No trouble for me... rake test returns without errors...

[ScotterC]

Cool Thanks . It's merged now.

[maintux]

you're welcome :-) let me know if you provide a new patch for the gem on rubygems so I can update my gemfile ;-)