John Morrison jrgm

  • Joined on

Organizations

@mozilla
@jrgm
[dont-merge-yet] match current config of {latest,stage}.dev.lcip.org as not doing CSP
jrgm commented on pull request mozilla/fxa-content-server#2156
@jrgm

Going to close this and revisit later. (No benefit in having an open PR that is not moving)

jrgm commented on pull request mozilla/fxa-oauth-server#240
@jrgm

Looks good to me!

jrgm deleted branch update-train-35 at jrgm/fxa-dev
jrgm opened pull request mozilla/fxa-dev#137
@jrgm
chore(stable): bump content,oauth,profile versions to train-35
1 commit with 3 additions and 3 deletions
jrgm created branch update-train-35 at jrgm/fxa-dev
jrgm commented on pull request mozilla/fxa-auth-server#917
@jrgm

I can fill in a test I have in a local tree later.

jrgm commented on pull request mozilla/fxa-auth-server#917
@jrgm

Yeah, that's what I meant in the other issue. r+

jrgm commented on pull request mozilla/fxa-auth-mailer#40
@jrgm

Like so? mozilla/fxa-auth-server#917 Yeah, that's what I meant. I was also going to add a test to call the translator with all the languages (and…

jrgm commented on pull request mozilla/fxa-auth-mailer#40
@jrgm

cross ref #39

jrgm commented on pull request mozilla/fxa-auth-mailer#40
@jrgm

fxa-auth-server will need to add defaultLanguage here https://github.com/mozilla/fxa-auth-server/blob/master/mailer.js#L14

jrgm commented on pull request mozilla/fxa-auth-mailer#40
@jrgm

Okay, took me a couple of takes, but this is simpler. Feel free to point out how wrong I am. r? dannycoates

@jrgm
  • @jrgm fc5ebbe
    fix(l10n): make defaultLanguage configurable, and switch to "en" default
@jrgm
  • @jrgm f33454e
    fix(l10n): make defaultLanguage configurable, and switch to "en" default
@jrgm
  • @jrgm 396ed20
    fix(l10n): make defaultLanguage configurable, and switch to "en" default
@jrgm
  • @jrgm 3a0aa4c
    better with fxa-auth-server
jrgm opened pull request mozilla/fxa-auth-mailer#40
@jrgm
fix(l10n): make defaultLanguage configurable, and switch to "en" default
1 commit with 18 additions and 7 deletions
@jrgm
  • @jrgm ed36694
    fix(l10n): make defaultLanguage configurable, and switch to "en" default
@jrgm
  • @jrgm 995166e
    fix(l10n): make defaultLanguage configurable, and switch to "en" default
jrgm commented on issue mozilla/fxa-auth-mailer#39
@jrgm

Draft of a fix at master...jrgm:fix-l10n-aargh

@jrgm
[train-35][prod] 500 errors due to change in defaultLanguage
jrgm commented on pull request mozilla/fxa-auth-server#916
@jrgm

Did you want to add this script to the .travis.yml file? It is part of .travis.yml via npm test, but intentionally it does not fail.

jrgm commented on pull request mozilla/fxa-auth-server#916
@jrgm

Pushed a fix to use .get not .post (copy paste mistake which surprisingly worked irregardless).

@jrgm
  • @jrgm eb50c89
    fix(mailer): add a soft check that we are using the same locales as c…
jrgm commented on pull request mozilla/fxa-auth-server#916
@jrgm

POST is the new GET? (Apparently on raw.githubusercontent.com).

jrgm commented on pull request mozilla/fxa-auth-server#916
@jrgm

I guess mentions in private repos don't get reflected here (for obviously correct reasons). Anyways, I'd already put in https://github.com/mozilla-…

jrgm opened pull request mozilla/fxa-auth-server#916
@jrgm
Check that we are using same locales as fxa-content-server
2 commits with 104 additions and 8 deletions
jrgm commented on pull request mozilla/fxa-auth-db-mem#29
@jrgm

So, in fxa-profile-server, I didn't put allow_failures in place since I want to know if there is a failure. With allowed_failures, there is no noti…