Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lodash.unescape with escape-goat #65

Merged
merged 1 commit into from Jul 8, 2020
Merged

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jul 3, 2020

Lodash per function packages are deprecated and will be removed in v5.
It's a good reason to use small isolated module instead of large package.

Note: escape-goat requires node v10

@TrySound
Copy link
Contributor Author

TrySound commented Jul 3, 2020

cc @jrit

Copy link
Owner

@jrit jrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs a merge conflict resolved

Lodash per function packages are deprecated and will be removed in v5.
It's a good reason to use small isolated module instead of large package.

Note: escape-goat requires node v10
@TrySound
Copy link
Contributor Author

TrySound commented Jul 8, 2020

Oops :)

@jrit
Copy link
Owner

jrit commented Jul 8, 2020

Oops :)

haha

@jrit jrit merged commit 90bd485 into jrit:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants