Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinstonLutz commits for Elekta EPID compatibility #67

Merged
merged 5 commits into from May 5, 2016

Conversation

Projects
None yet
3 participants
@midamo
Copy link
Contributor

commented May 3, 2016

I applied various fixes to make the WL analysis compatible with Elekta Agility and Iview EPID. Seems to work for me but I will continue validating the results later. Also, I didn't test my changes with other linacs... I may have broken something for someone else.

midamo added some commits May 2, 2016

WL : Image trimming for accurate field_cax
There is an artefact line present in all elekta EPID images. The first pixel line at the left has wrong pixel values. It perturbs the field_cax determination.
@@ -366,6 +366,10 @@ def __init__(self, file):
self.check_inversion()
# Flip the image upside down... makes it more intuitive later on.
self.flipud()
# The first pixel line on the left has a glitch on Elekta iview EPID

This comment has been minimized.

Copy link
@jrkerns

jrkerns May 3, 2016

Owner

Do you have a sample dataset to show this effect? And how confident are you that this is true for all Elektas?

This comment has been minimized.

Copy link
@midamo

midamo May 4, 2016

Author Contributor

Need to double check with a few collegues... I should have a confirmation in a few days.

This comment has been minimized.

Copy link
@jrkerns

jrkerns May 4, 2016

Owner

No problem. Once you confirm that and upload a dataset with the issue I'll merge.

This comment has been minimized.

Copy link
@midamo

midamo May 5, 2016

Author Contributor

The datasets already provided contains this glitch.

I am also able to confirm that this glitch is common for Elektas (4 hospitals, sample of ~ 15 linacs). It doesn't appears on all of them though­. It affects the field_cax position by about 0.5 mm (for a 10x10 field). Clipping may not be only option, but it is a quick and safe one. An elekta EPID is 1024x1024 pixels.... 1023x1024 doesn't really affect the covered area. Feel free to use another fix if you prefer.

This comment has been minimized.

Copy link
@jrkerns

jrkerns May 5, 2016

Owner

Okay, that's fine. I just wanted to make sure this wasn't occurring on just your machine and no one else's. I'll merge this and add some tests and release a bugfix update. Thanks for your contribution!

@jrkerns

This comment has been minimized.

Copy link
Owner

commented May 3, 2016

@midamo This is a good fix. Don't worry about testing for Varian; I have plenty of datasets there to make sure there are no bugs that break the system. Any further Elekta fixes are welcome, just upload the datasets that weren't working or that you based the fixes on to the dropbox folder so I can add them to the test suite to make sure further changes don't break our progress =) Thanks!

@coveralls

This comment has been minimized.

Copy link

commented May 3, 2016

Coverage Status

Coverage decreased (-0.05%) to 88.648% when pulling 926a3d2 on midamo:master into c42680c on jrkerns:master.

@jrkerns jrkerns merged commit f7d3e72 into jrkerns:master May 5, 2016

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.05%) to 88.648%
Details
QuantifiedCode No new issues found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jrkerns added a commit that referenced this pull request May 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.