Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one more test to pySearch #23

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
2 participants
@giantpanpan
Copy link

commented Nov 15, 2018

add a test to verify the google search string match with the google url format

giantpanpan added some commits Nov 15, 2018

Add files via upload
add a test to verify the google search string match with the google url format
Add a new test for twitter
add a test to verify the twitter search string match with the twitter search url format
Add a test for twitter search
add a test to verify the twitter search string match with the twitter url format
Add a test for twitter search
add a test to verify the google search string match with the google url format
Merge pull request #1 from giantpanpan/test_twitter
Add a test for twitter search
@jrkong
Copy link
Owner

left a comment

These are great changes however this PR targets the test-framework branch which isn't the master branch, can you create another PR which target the master branch?

import pytest

from ..search import Search

This comment has been minimized.

Copy link
@jrkong

jrkong Nov 23, 2018

Owner

Remove extra whitespace here

@jrkong

This comment has been minimized.

Copy link
Owner

commented Nov 23, 2018

You have 2 PRs open that add the google test. I think we should close this PR and add the google test onto the twitter test PR. Alternatively we can open a new PR which has both of these changes which target the master branch. Which option do you want to go with?

@giantpanpan giantpanpan closed this Dec 7, 2018

@giantpanpan giantpanpan deleted the giantpanpan:test-framework branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.