Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some Tests #40

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Mera-Gangapersaud
Copy link
Contributor

commented Dec 8, 2018

per issue #16 this PR writes tests for:

  • twitter search
  • google search
  • amazon search
  • default search
  • setting domain

Each test checks for one setting at a time. ie. twitter test checks that the url is correct when only the search query and engine are set.

**Note that for the twitter search to work correctly the search.py had to be altered as I realized the twitter searches used %20 for spaces as well. The test also made apparent that setting the domain for twitter should not be allowed since twitter.ca does not exist. Therefore when the engine is twitter the domain is automatically set to com

I also noticed that the ReadMe had a mistake for the pip installation and added a fix for that.

@pep8speaks

This comment has been minimized.

Copy link

commented Dec 8, 2018

Hello @Mera-Gangapersaud! Thanks for updating the PR.

Comment last updated on December 08, 2018 at 09:29 Hours UTC

@Mera-Gangapersaud Mera-Gangapersaud force-pushed the Mera-Gangapersaud:tests branch from 37909c1 to 8b24bd4 Dec 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.