Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

I love the idea of the code, but there is so much duplication! #4

Merged
merged 3 commits into from

2 participants

@tonydew

I really like the idea of Mahana, but there was so much code duplication throughout. In the spirit of DRY, I refactored the library to eliminate most of the duplicated code. I also added doc blocks to the library and the model.

In this PR, the initial require_once() for the config file has been tweaked to work with HMVC as well as a standard CodeIgniter install.

Finally, I fixed up the model so it works with dbprefix set.

@jrmadsen67
Owner

thanks! this was written a looong time ago & I've never really gone back and looked at it too critically. I'll review & pull changes tonight

@jrmadsen67 jrmadsen67 merged commit b5581ee into jrmadsen67:master
@tonydew

Awesome! Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 6, 2013
Commits on Feb 7, 2013
  1. Massive refactor. Logic is mostly the same, but a lot of duplicated c…

    Tony Dew authored
    …ode was eliminated.
  2. Code clean up and doc blocks

    Tony Dew authored
Something went wrong with that request. Please try again.