Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

I love the idea of the code, but there is so much duplication! #4

Merged
merged 3 commits into from Feb 7, 2013

Conversation

Projects
None yet
2 participants

tonydew commented Feb 7, 2013

I really like the idea of Mahana, but there was so much code duplication throughout. In the spirit of DRY, I refactored the library to eliminate most of the duplicated code. I also added doc blocks to the library and the model.

In this PR, the initial require_once() for the config file has been tweaked to work with HMVC as well as a standard CodeIgniter install.

Finally, I fixed up the model so it works with dbprefix set.

thanks! this was written a looong time ago & I've never really gone back and looked at it too critically. I'll review & pull changes tonight

jrmadsen67 added a commit that referenced this pull request Feb 7, 2013

Merge pull request #4 from tonydew/master
I love the idea of the code, but there is so much duplication!

@jrmadsen67 jrmadsen67 merged commit b5581ee into jrmadsen67:master Feb 7, 2013

tonydew commented Feb 7, 2013

Awesome! Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment