New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USES=c++ does not enforce that a subpackage is specified #2

Closed
mneumann opened this Issue Jan 7, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@mneumann
Copy link

mneumann commented Jan 7, 2018

No description provided.

@mneumann

This comment has been minimized.

Copy link

mneumann commented Jan 7, 2018

I think it should be USES=c++:single instead of USES=c++ but, this is not enforced by ravenadm.

@jrmarino

This comment has been minimized.

Copy link
Owner

jrmarino commented Jan 7, 2018

yes, this should be a sanity check.

jrmarino added a commit that referenced this issue Jan 8, 2018

Sanity check, take 2 (issue #2)
1. check the correct string
2. raise wrong_value exception instead of wrong_type

jrmarino added a commit that referenced this issue Jan 8, 2018

sanity check, take 3 (issue #2)
The part2 function returns part1 if there is no delimiter.  This is not
wanted; we need a blank string returned in the absence of delimitor

jrmarino added a commit that referenced this issue Jan 8, 2018

Sanity check, take 4 (issue #2)
I'm starting to remember why no validity existed before.  Compiler
modules can specify any number of subpackages (separated with a comma),
so the string has to be split and checked in a loop, otherwise valid
values like "clover,drivers,osmesa" are falsely tagged as errors.
@jrmarino

This comment has been minimized.

Copy link
Owner

jrmarino commented Jan 8, 2018

fixed with release of v0.86

@jrmarino jrmarino closed this Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment