Help windows #110
Merged
Help windows #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix small typo in CONTRIBUTING.md
for multiline input on Windows, you need Ctrl+Z to exit
trying to wrap lines at 80 char in Windows' CMD results in blank lines following lines that are exactly 80 char long
Contributor
|
Awesome, thank you so much! I think you're missing an import sys there, then tests will pass as well :) |
Contributor
|
On second thought, in happy to change the default line wrap to 79 or 78 globally. Let's not make a special case for win there. |
Contributor
Author
|
I've updated the code to that lines wrap at 79 chars globally |
Contributor
|
Fantastic, thanks for your effort! |
Contributor
Author
|
thanks for making it to easy to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of random typos and tried to make the program work nicer on Windows systems. Changes should only effect Windows installations. Specifically:
P.S. Very cool piece of software :)