Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more steps to pytest, fully remove behave #1347

Merged
merged 7 commits into from Oct 9, 2021
Merged

Add more steps to pytest, fully remove behave #1347

merged 7 commits into from Oct 9, 2021

Conversation

wren
Copy link
Member

@wren wren commented Oct 2, 2021 •
edited

  • Fully remove behave
  • Implement in pytest the last few tests that hadn't been migrated

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

wren and others added 4 commits October 2, 2021 13:47
@wren
update yaml loader to new method
e16e3a1
@wren @micahellison
Add config overrides steps to pytest
9cd2250 
This requires some patching around the config object, which now happens
in every test.

Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>
@wren
udpate docs for new tests
02bdc39
@wren
remove behave from deps
7c06569
@wren wren changed the title Add more steps to pytest Add more steps to pytest, fully remove behave Oct 3, 2021
micahellison
micahellison approved these changes Oct 9, 2021
View reviewed changes
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪🧪🧪

@micahellison
Copy link
Member

Checks one of the boxes of #1287

@micahellison micahellison added build Issues related to the build pipeline test Issues related to tests we need to add labels Oct 9, 2021
@micahellison micahellison merged commit 44edb9b into jrnl-org:develop Oct 9, 2021
@micahellison micahellison deleted the config-override-spy-1287 branch October 9, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahellison micahellison micahellison approved these changes

Assignees
No one assigned
Labels
build Issues related to the build pipeline test Issues related to tests we need to add
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wren @micahellison