Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dayone] remove extra spaces from the titles of edited DayOne entries #350

Open
wants to merge 14 commits into
base: master
from

Conversation

@MinchinWeb
Copy link
Collaborator

commented May 10, 2015

Otherwise, a leading space was being introduced

@MinchinWeb

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 4, 2015

Now also maintains existing metadata (location, weather, creator) on Dayone entries across edits.

@MinchinWeb

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 4, 2015

Manually resolved merge conflict with #355

@flight16

This comment has been minimized.

Copy link

commented Jun 5, 2015

Thanks for the leading space fix. I encountered this issue, too. Looking forward to it getting merged back into the 2.0 branch.

@wren wren changed the base branch from 2.0-rc1 to master Jul 7, 2019
@wren

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Is this PR still relevant? It seems like fixes for Day One before their 2.0 release is outdated, but I honestly don't know if people still use the older Day One client.

@wren wren added the bug label Jul 7, 2019
@MinchinWeb

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

@wren I actually use a DayOne Classic compatible client on Windows. (DayOne has never released official client for Windows).

@wren

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

@MinchinWeb Which client? Are there any similar client for Mac? Do you know if Day One supports their old client anymore?

@MinchinWeb

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 8, 2019

I'm using Journaley. I don't have a Mac, so I've never gone looking for something similar there. I rather doubt Day One is still supporting their old clients; it seems they haven't updated it to work with Dropbox's new API.

This also helps with old entries, written in the original DayOne (iPad/iPhone) client when it was still current.

@MinchinWeb MinchinWeb dismissed a stale review via e188b83 Aug 2, 2019
@MinchinWeb MinchinWeb force-pushed the MinchinWeb:2.0-dayone-fixes branch from de83d00 to e188b83 Aug 2, 2019
MinchinWeb added 3 commits Aug 2, 2019
@MinchinWeb

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 2, 2019

@wren this has been rebased against the current master, add all test are passing. It should be ready to be merged!

These are all bug fixes, so I'd love it if it made the 2.0 cutoff.

@MinchinWeb MinchinWeb referenced this pull request Aug 2, 2019
@MinchinWeb

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 2, 2019

We may need to review what we're doing with line endings. This is one of the raw strings that was being testing against:

'2010-06-10 15:00 A life without chocolate is like a bad analogy.\r\n\n2013-06-10 15:40 He said "[this] is the best time to be alive".\r'

(notice the total mis-match of line endings.) Some of it, I'm sure, is due to Windows, and some due to Git, but it was making for tests that passed on Travis, but failed locally.

@stale

This comment has been minimized.

Copy link

commented Oct 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 1, 2019
@stale stale bot removed the stale label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.