Permalink
Commits on Aug 18, 2010
  1. comments

    committed Aug 18, 2010
  2. remove errant debugger line

    committed Aug 18, 2010
  3. don't run init code in testing environment. Kind of weird, but had to…

    … do it to make things work, since all the classes that init code tries to patch are not available in testing environment. Tests now run, at least. Work in progress.
    committed Aug 18, 2010
  4. this spec no longer relevant to current code; we really should write …

    …another spec that is
    committed Aug 18, 2010
Commits on Aug 17, 2010
  1. got the dismax spec to pass under new architecture, with difficulty. …

    …No new specs written, just getting existing specs to pass.
    committed Aug 17, 2010
  2. remove done item from to do

    committed Aug 17, 2010
  3. Replace "clear form" form reset button with a "start over" button tha…

    …t actually reloads the page fresh. This handles getting rid of 'search context' too.
    committed Aug 17, 2010
  4. For search form within an existing search context, display facets as …

    …fetched/calculated within that context.
    
    This ended up being a bit tricky. We need to execute our solr facet fetch with all parameters appropriate for the current search context, _including_ those added by other plugins. To do that, AdvancedController now sub-classes CatalogController,
    so CatalogController#solr_search_params can be called, since that's the one that has been plugin-enhanced. The params
    returned by solr_search_params then have all facet-related params removed, along with other params we're not interested in.
    
    Not entirely sure how this will effect things if you use a different request handler for advanced; probably depends on
    the individual plugin, should work fine with the 'officialish' ones we have already.
    
    Additionally, AdvancedController now 'include's AdvancedHelper, to get access to the #advanced_search_context method,
    to see if there is an existing search context that needs to be taken account of in facet fetch.
    committed Aug 17, 2010
  5. specing BL behavior itself from inside the plugin is just too hard to…

    … get working. I see how it's a valuable thing to do, but just can't make it work in a reasonable way. BL in Rails3 as a gem will make this much more feasible.
    committed Aug 17, 2010
Commits on Aug 16, 2010
  1. to do item for quoted phrases

    committed Aug 16, 2010
  2. semi-colon

    committed Aug 16, 2010
  3. template installer will optionally install local search form with lin…

    …k to advanced search
    committed Aug 16, 2010
  4. make 'clear form' button work even on pre-filled form, by manually un…

    …setting instead of using form.reset
    committed Aug 16, 2010
  5. make reset js unobtrusive

    committed Aug 16, 2010
  6. get right column to be full width despite the weird things we did to …

    …get vertical scrollbar
    committed Aug 16, 2010
  7. make sure scrollbar shows up in right place by setting right/left in …

    …absolute positioned div
    committed Aug 16, 2010
  8. remove typo

    committed Aug 16, 2010
  9. unobtrusify checkbox JS

    committed Aug 16, 2010