Jonathan Rochkind
jrochkind

Organizations

@projectblacklight @ruby-marc @openurl @team-umlaut @marc4j
Jul 22, 2016
jrochkind commented on pull request team-umlaut/umlaut_borrow_direct#1
@jrochkind

@barnabyalter okay I've added you as an 'admin' level owner of the repo, as well as a rubygems owner so you can do releases. Thank you! I apprecia…

Jul 22, 2016
jrochkind commented on pull request team-umlaut/umlaut_borrow_direct#1
@jrochkind

Weird, I try to add you as a commiter copying and pasting your github account name from this page, and it tells me "@barnabyalter isn't a github me…

Jul 21, 2016
jrochkind commented on pull request team-umlaut/umlaut_borrow_direct#1
@jrochkind

Also note for reference, here's the link to the Umlaut-provided register_routes method. The comments note it's experimental and we'll see how it wo…

Jul 21, 2016
jrochkind commented on pull request team-umlaut/umlaut_borrow_direct#1
@jrochkind

@barnabyalter hey, thanks for finding and debugging this. I'm not maintaining this heavily, but keep an eye on it. I could merge your change, but…

Jul 20, 2016
jrochkind commented on pull request solidusio/solidus#1218
@jrochkind

Without this, if I want to write a new back-end replacing ActionMailer delivery with another delivery mechanism (likely an HTTP api, say, mailgun; …

Jul 20, 2016
jrochkind commented on pull request solidusio/solidus#1218
@jrochkind

I think it important to be able to switch out an ActionMailer back-end for another back-end (likely using a third party HTTP API), without having t…

Jul 20, 2016
@jrochkind

MRI 2.3.1. I wasn't able to reduce to an isolated reproduction. I ended up just refactoring my code in a way that no longer seemed to trigger the nil

Jul 12, 2016
jrochkind commented on pull request solidusio/solidus#1323
@jrochkind

@tvdeyen Capybara actually requires you to do case-sensitive matching on what actually is rendered by the browser. It is intentional on Capy's part…

Jul 12, 2016
@jrochkind

Weirder: delay.wait #=> returns self delay.pending? #=> true Huh? I have no doubt I am doing something impossible in my code, trying to track it d…

Jul 12, 2016
@jrochkind
Debugging a weird Concurrent::Delay
Jul 12, 2016
jrochkind commented on pull request solidusio/solidus#1323
@jrochkind

thank you! I was just looking at this styling and wishing for exactly what you did.

Jul 12, 2016
jrochkind commented on pull request solidusio/solidus#1114
@jrochkind

Okay, I think this is confusing enough that some documentation is def going to be required for people to figure it out. I still suggest that in the…

Jul 12, 2016
jrochkind commented on pull request solidusio/solidus#1114
@jrochkind

okay, maybe I kind of sort of understand. this still seems pretty tricky reading the code. I'd suggest some brief docs explaining how it all works …

Jul 12, 2016
jrochkind commented on pull request solidusio/solidus#1114
@jrochkind

This is insisting on adding the class name new-layout if @admin_layout is set at all. Is admin_layout a boolean, or is the name of a (I think) clas…

Jul 12, 2016
jrochkind commented on pull request solidusio/solidus#1114
@jrochkind

As I look at this code more though, the name admin_layout is a bit confusing to me -- I thought it would be a Rails layout template, but it looks l…

Jul 11, 2016
jrochkind commented on pull request solidusio/solidus#1316
@jrochkind

I think it would probably be better to still see the SKU's without a tooltip hover. They are the main identifying features of a product for many of…

Jul 8, 2016
@jrochkind
Support Rails5 indexed nested attribute errors
Jul 8, 2016
jrochkind commented on pull request solidusio/solidus#1311
@jrochkind

This is confusing me, even with the comment. It overrides the let(:user) { create(:user) } on line 5? I thought that user on line 5 was the logged …

Jun 29, 2016
@jrochkind
upgrading to solidus 1.3, "Database has no stores. One should have been created in a previous migration."
Jun 29, 2016
jrochkind commented on issue solidusio/solidus#1283
@jrochkind

jhawthorn says in slack migraitons aren't intended to work in test like that. https://solidusio.slack.com/archives/solidus/p1467225143000964

Jun 29, 2016
jrochkind commented on issue solidusio/solidus#1283
@jrochkind

I just added this to my locally copied migration store = Store.first if Rails.env.test? store = Store.create!(code: "spree_1", name: "Spree Test S…

Jun 29, 2016
@jrochkind
upgrading to solidus 1.3, "Database has no stores. One should have been created in a previous migration."
Jun 29, 2016
jrochkind commented on pull request solidusio/solidus#1091
@jrochkind

Makes sense, thanks @jordan-brough

Jun 29, 2016
@jrochkind

I am getting this error with Geometry on an svg file. I debugged to see: $ identify -format '%wx%h,%[exif:orientation]' '/var/folders/8m/dfpc7lkn13…

Jun 27, 2016
jrochkind commented on issue solidusio/solidus#1229
@jrochkind

readonly! will make that particular in-memory copy refuse to save changes, but some other part of code could still change the same row in the db.

Jun 25, 2016
jrochkind commented on pull request solidusio/solidus#1273
@jrochkind

Nice work!

Jun 25, 2016
jrochkind commented on issue solidusio/solidus#1272
@jrochkind

I've worked on a Rails engine that supported Rails 3 and 4 with few or no (can't remember for sure if it was zero) Rails.version checks, just a few r…

Jun 24, 2016
jrochkind commented on issue solidusio/solidus#1272
@jrochkind

Are you sure it's unrealistic to support both rails 4 and 5? It might be worth at least considering if that's possible, when looking at the test fa…

Jun 24, 2016
jrochkind commented on pull request solidusio/solidus#1091
@jrochkind

@dhonig So STI has already been 'introduced', this would not be introducing it. If Spree::PaymentMethod and Spree::Gateway are both already STI, th…