Permalink
Browse files

make a note about fixing the phoenix rank issue

  • Loading branch information...
1 parent f1ed082 commit 4c42101ec6fa7a49b08f8dc7a085767b8cbf43d2 @jrockway committed Dec 26, 2012
Showing with 3 additions and 1 deletion.
  1. +2 −0 src/Cards.hs
  2. +1 −1 src/Plays.hs
View
2 src/Cards.hs
@@ -37,6 +37,8 @@ instance Show Suit where
allSuits = enumFrom Jade
+-- TODO(jrockway): Support fractional ranks (issues/1).
+
-- | Represents the rank of a card. Implements Num so you can use Integer
-- literals where a Rank is required.
newtype Rank = Rank Int
View
2 src/Plays.hs
@@ -42,7 +42,7 @@ unwrapPlay (Wish x _) = unwrapPlay x
-- | Plays have ranks; the rank is the lowest card of a straight or cons pair,
-- the value of a single, pair, triple, or four-card bomb,
instance Ranked Play where
- rank (Single Phoenix) = 1 -- XXX
+ rank (Single Phoenix) = 1 -- TODO(jrockway): Fix after issues/1 is resolved.
rank (Single x) = rank x
rank (Multiple xs) = rank . arbitraryStandardCard $ xs
rank (Straight xs) = if Set.member Phoenix xs && min + len - 1 > 14 then

0 comments on commit 4c42101

Please sign in to comment.