Skip to content

Commit

Permalink
get rid of useless vfsmount_lock use in put_mnt_ns()
Browse files Browse the repository at this point in the history
It hadn't been needed since we'd sanitized the logics in
mark_mounts_for_expiry() (which, in turn, used to be a
rudiment of bad old times when namespace_sem was per-ns).

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Mar 3, 2010
1 parent 47cd813 commit d498b25
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions fs/namespace.c
Expand Up @@ -2344,17 +2344,13 @@ void __init mnt_init(void)

void put_mnt_ns(struct mnt_namespace *ns)
{
struct vfsmount *root;
LIST_HEAD(umount_list);

if (!atomic_dec_and_lock(&ns->count, &vfsmount_lock))
if (!atomic_dec_and_test(&ns->count))
return;
root = ns->root;
ns->root = NULL;
spin_unlock(&vfsmount_lock);
down_write(&namespace_sem);
spin_lock(&vfsmount_lock);
umount_tree(root, 0, &umount_list);
umount_tree(ns->root, 0, &umount_list);
spin_unlock(&vfsmount_lock);
up_write(&namespace_sem);
release_mounts(&umount_list);
Expand Down

0 comments on commit d498b25

Please sign in to comment.