Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hideOnCompletion not working in VisitWaypoint parameter #519

Closed
severedsolo opened this issue May 21, 2016 · 7 comments
Closed

hideOnCompletion not working in VisitWaypoint parameter #519

severedsolo opened this issue May 21, 2016 · 7 comments
Labels

Comments

@severedsolo
Copy link

severedsolo commented May 21, 2016

As above. Waypoints don't disappear when the VisitWaypoint is completed.

Can provide a contract if you need it, but I've removed them for now and turned showMessages on instead to work around it, so would need a little work to put them back (but happy to do it if you need it)

Edit: example contract with hideOnCompletion missing due to workaround: https://github.com/severedsolo/KerbalAcademy/blob/master/KerbalAcademyFlightSchool.cfg

@jrossignol jrossignol added the bug label May 21, 2016
@jrossignol jrossignol added this to the soon milestone May 21, 2016
@jrossignol
Copy link
Owner

Worked fine in Anomaly Surveyor's Kerbin monolith contract. I'll need a more detailed test case to understand what's going on for you. Also, it's not clear how showMessages is a workaround here.

@severedsolo
Copy link
Author

severedsolo commented May 24, 2016

showMessages was more "Let's get something that basically works, and I can see when I've hit that waypoint and move on to the next one".

With no other parameters, (and hideOnCompletion not working for me) just using "VisitWaypoint" the only way to see if you'd hit it was watch the contract window, so not watching the plane, which is inadvisable when you are doing high G turns above KSC.

So what seems to be happening is the waypoints are disappearing, but not while they are seledcted in Waypoint Manager. So, as an example in that contract above, the 1st waypoint disappeared when I completed the 2nd one, because that was no longer selected in WPM (I guess it only checks for waypoints to hide when you actually complete one).

You might need a log or something, let me know. The original hope was that WPM would auto select the next waypoint, like it does when you complete a stock contract.

@jrossignol
Copy link
Owner

Note that WPM doesn't really "select" a waypoint (it's just a passthrough to the stock mechanic of the active waypoint). So it shouldn't change anything here. I'll do another test with the waypoint selected.

@jrossignol
Copy link
Owner

Right, now I get it. It doesn't disappear from the list in Waypoint Manager, so it's a bug there.

If you want some auto-select logic to select the "next" waypoint, raise an enhancement and I'll implement that.

@jrossignol
Copy link
Owner

Raised jrossignol/WaypointManager#47, closing this issue.

@severedsolo
Copy link
Author

Ok that would be awesome, do you want the issue raised under this or WPM?

@jrossignol
Copy link
Owner

It would need to be Contract Configurator logic, so here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants