New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search functionality #203

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ginberg

ginberg commented Nov 19, 2017

Added basic search functionality like it is described on the handsontable page
https://docs.handsontable.com/0.31.2/demo-searching.html

Changes

  • upgraded to handsontable 0.34.5
  • added search option to handsontable constructor
  • added an example shiny app
@jrowen

This comment has been minimized.

Owner

jrowen commented Jan 4, 2018

This looks great. Do you want to add yourself as a contributor to the DESCRIPTION file? Also, would it make sense to add something to the doc page?

@ginberg

This comment has been minimized.

ginberg commented Jan 5, 2018

Thanks, I am glad you like it.
Sure I just added myself as contributor & merged your changes.

We can add something to the doc page indeed. Shall I do it or do you want to do it? I guess I would just create a link to the example search shiny app

jrowen added a commit that referenced this pull request Jan 6, 2018

@jrowen

This comment has been minimized.

Owner

jrowen commented Jan 6, 2018

I updated the doc. Thanks again for submitting.

@jrowen jrowen closed this Jan 6, 2018

@ginberg

This comment has been minimized.

ginberg commented Jan 8, 2018

no problem! Nice that you have created an example via the context menu, I didn't think of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment