Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
I should be able to override jruby.defaultVersion or execVersion from the command line #131
@ysb33r I'm fine with a system property, I can kind of understand why you don't think the functionality that the code should go into the plugin.
I think there is immense benefit to JRuby users and the JRuby core team by enabling this functionality across the board by default for jruby-gradle users. That would make it absolutely trivial for jruby-gradle projects to contribute feedback to the project on the success of jruby 9k which is pretty important IMO
I am with you on that. It will also allow to set up an additional travis axis to compile with the normal & 9K
I think you just need to do something like
String defaultVersion = System.getProperty('jruby.defaultVersion') ?: '1.7.20' String execVersion = System.getProperty('jruby.execVersion') ?: defaultVersion
I'm back to thinking this should be a project property which affords the user the greatest amount of flexibility (IMHO) since they can take advantage of the
For projects at Lookout we're using