New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packing JRubyJar shouldn't include a jruby-mains.jar #193

Closed
rtyler opened this Issue Aug 16, 2015 · 0 comments

Comments

1 participant
@rtyler
Member

rtyler commented Aug 16, 2015

Since jruby-mains is unzipped into the destination archive, there's no need to include the raw version of the file in the archive as well

@rtyler rtyler added this to the 1.1.0 - Dresden milestone Aug 16, 2015

rtyler added a commit to rtyler/jruby-gradle-plugin that referenced this issue Aug 16, 2015

Move jrubyMains into task-specific configuration for embedding into t…
…he jrubyjar

I probably should have done this in the first place but I was overly reluctant
to introduce tasks-specific configurations. After fighting with the
configuration resolution lifecycle and jruby.defaultVersion last week, I've
learned from the error of my ways

Fixes jruby-gradle#193

@rtyler rtyler closed this in #194 Aug 17, 2015

rtyler added a commit to rtyler/jruby-gradle-plugin that referenced this issue Sep 10, 2015

Move jrubyMains into task-specific configuration for embedding into t…
…he jrubyjar

I probably should have done this in the first place but I was overly reluctant
to introduce tasks-specific configurations. After fighting with the
configuration resolution lifecycle and jruby.defaultVersion last week, I've
learned from the error of my ways

Fixes jruby-gradle#193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment