New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepareJRubyJar doesn't cache results and reinstalls gems every single run #220

Closed
rtyler opened this Issue Sep 10, 2015 · 2 comments

Comments

2 participants
@rtyler
Member

rtyler commented Sep 10, 2015

Because we're now installing gems into build/dirinfo/jrubyJar by default, this line ensures that the directory is completely cleaned every time the JRubyDirInfo object is instantiated.

This is obviously problematic. And this should be backported to v1.0.4

Originally identified as jruby-gradle/jruby-gradle-storm-plugin#22

@rtyler rtyler added bug jar labels Sep 10, 2015

@rtyler rtyler self-assigned this Sep 10, 2015

@rtyler rtyler added this to the 1.1.0 - Dresden milestone Sep 10, 2015

@mkristian

This comment has been minimized.

Show comment
Hide comment
@mkristian

mkristian Sep 10, 2015

Contributor

this current implementation is problematic due to following issues:

+1 for a better implementation

Contributor

mkristian commented Sep 10, 2015

this current implementation is problematic due to following issues:

+1 for a better implementation

@rtyler

This comment has been minimized.

Show comment
Hide comment
@rtyler

rtyler Sep 10, 2015

Member

I think I'll remove the deleteDir from now to prevent this regression and open another enhancement request to more cleanly stage and generate the .jrubydir information when we create the jar artifact instead of the stage directory

Member

rtyler commented Sep 10, 2015

I think I'll remove the deleteDir from now to prevent this regression and open another enhancement request to more cleanly stage and generate the .jrubydir information when we create the jar artifact instead of the stage directory

rtyler added a commit to rtyler/jruby-gradle-plugin that referenced this issue Sep 10, 2015

Prevent new instantiations of JRubyDirInfo from deleting the dirinfo …
…directory

This will allow the dirinfo directory to be used as a staging ground but as
@mkristian correctly points out, this means the dirinfo directory will get more
and more stale/inaccurate as time goes on. This necessitates a refactored
approach to generating the .jrubydir files and injecting them into the packed
jar file

Fixes #220

rtyler added a commit to rtyler/jruby-gradle-plugin that referenced this issue Sep 10, 2015

Prevent new instantiations of JRubyDirInfo from deleting the dirinfo …
…directory

This will allow the dirinfo directory to be used as a staging ground but as
@mkristian correctly points out, this means the dirinfo directory will get more
and more stale/inaccurate as time goes on. This necessitates a refactored
approach to generating the .jrubydir files and injecting them into the packed
jar file

Fixes #220

@rtyler rtyler closed this in #221 Sep 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment