Permalink
Browse files

We rely on these exceptions being tossed in TorqueBox when a database…

… doesn't support transactions. Eating them causes us problems. One could argue that it might lead to surprising results if errors occur in the callbacks around a save. Since InnoDB supports transactions, and it's the default engine starting with MySQL 5.5, I propose we toss exceptions when tx's aren't supported.
  • Loading branch information...
1 parent 6377c53 commit 81d9c2c112bdc5e36be323134454794ce085b5e2 @jcrossley3 jcrossley3 committed Sep 27, 2011
Showing with 0 additions and 18 deletions.
  1. +0 −18 lib/arjdbc/mysql/adapter.rb
@@ -138,24 +138,6 @@ def quoted_false
"0"
end
- def begin_db_transaction #:nodoc:
- @connection.begin
- rescue Exception
- # Transactions aren't supported
- end
-
- def commit_db_transaction #:nodoc:
- @connection.commit
- rescue Exception
- # Transactions aren't supported
- end
-
- def rollback_db_transaction #:nodoc:
- @connection.rollback
- rescue Exception
- # Transactions aren't supported
- end
-
def supports_savepoints? #:nodoc:
true
end

0 comments on commit 81d9c2c

Please sign in to comment.