5.1.22 version breaks sequel integration #280

Closed
aportnov opened this Issue Dec 26, 2012 · 4 comments

Comments

Projects
None yet
2 participants

Removal of
require "mysql-connector-java-#{Jdbc::MySQL::VERSION}.jar" in version 5.1.22 breaks jdbc-mysql compatibility with sequel framework.

Owner

kares commented Dec 27, 2012

could you maybe please elaborate why/ how does it break sequel integration ? thanks
the jar sill gets required just not up front since than multiple driver jars might have ended on CP that never got used ...

Karol,

Sorry I should've provided a bit more info to begin with.
When using jdbc-mysql gem outside of active record, in my case with
framework called sequel, the changes that were made in 5.1.22 break
backwards compatible. Sequel basically does
require 'jdbc-mysql' (which used to require a jar)
The problem is that now they need to do something different defending on
the version of the jdbc gem being used. Or force consumers, like me, to be
version aware and load driver before loading sequel and trying to connect.

Thanks,
Alex
On Dec 27, 2012 4:12 AM, "Karol Bucek" notifications@github.com wrote:

could you maybe please elaborate why/ how does it break sequel integration
? thanks
the jar sill gets required just not up front since than multiple driver
jars might have ended on CP that never got used ...


Reply to this email directly or view it on GitHubhttps://github.com/jruby/activerecord-jdbc-adapter/issues/280#issuecomment-11704860.

Owner

kares commented Dec 27, 2012

Hey Alex, thanks for your reply ... I'm really sorry to break sequel compatibility (since Sequel seems pretty useful :))
I really wanted to change the auto-loading since it seemed to do quite a few redundancies and confused me while looking at an application's loaded features/files trying to figure out a JDBC driver related issue (+ it allows for more flexible reuse of the packaged driver gems - I myself am going to reuse those). Gems are primarily for AR-JDBC but I understand that it seems hard to deal with such change since we're not sem-versioning the gems. But maybe Sequel can adapt it does not need to be version aware just feature aware jeremyevans/sequel#598

Owner

kares commented Jan 7, 2013

no longer - merged on sequel's side - anyways thanks for reminding us ...

kares closed this Jan 7, 2013

Unknown referenced this issue in influitive/apartment Jan 18, 2013

Merged

JDBC Support #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment