Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[rails 4.1] create_table_definition changed from 3 to 4 parameters. #522

Closed
jcoyne opened this Issue Dec 18, 2013 · 6 comments

Comments

Projects
None yet
4 participants

jcoyne commented Dec 18, 2013

Introduced here: rails/rails@75a2e4a

senny commented Dec 18, 2013

I hope we can get this resolved before Rails 4.1 ships. Updating the signature should be good enough to get it working:

def create_table_definition(name, temporary, options)

@garysweaver garysweaver added a commit to FineLinePrototyping/irie that referenced this issue Dec 18, 2013

@garysweaver garysweaver fixing Rails 4.1 test/appraisal to use 4.1 beta vs 4.0, scaling back …
…appraisal combos. for jruby/Rails 4.1+ issue see: jruby/activerecord-jdbc-adapter#522
7e7ef76
Contributor

garysweaver commented Dec 18, 2013

Does that work? Travis passed.

jcoyne commented Dec 19, 2013

It looks good, but there aren't any tests covering it.

Contributor

garysweaver commented Dec 19, 2013

@jcoyne K, but that means it wasn't covered before either right, because I am basically doing almost the same thing? Will see if I can add test(s) to run checking rails version 4.1+ to send in some table create SQL as the "as".

jcoyne commented Dec 19, 2013

@garysweaver Yeah, I hear you. It's definitely better now than before. You're the one with commit access, so run the project however you want. I'm sure you'd be happy to have a PR with tests, right? 😉

Owner

kares commented Dec 19, 2013

this should have failed anyways but since the rails-4.1 was not "yet" at the method signature change - it did not ...
I might be wrong here thus a test is welcome anyways, keep in mind that they need to be 1.8 syntax and that we run our tests all the way down to 2.3 ... thank you for caring about JRuby on Rails!

@kares kares closed this Dec 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment