You can clone with
HTTPS or Subversion.
Introduced here: rails/rails@75a2e4a
I hope we can get this resolved before Rails 4.1 ships. Updating the signature should be good enough to get it working: https://github.com/jruby/activerecord-jdbc-adapter/blob/23134e063ab2d5dab656a2aecbba9a6888e92504/lib/arjdbc/jdbc/adapter.rb#L703
fixing Rails 4.1 test/appraisal to use 4.1 beta vs 4.0, scaling back …
…appraisal combos. for jruby/Rails 4.1+ issue see: jruby/activerecord-jdbc-adapter#522
Does that work? Travis passed.
It looks good, but there aren't any tests covering it.
@jcoyne K, but that means it wasn't covered before either right, because I am basically doing almost the same thing? Will see if I can add test(s) to run checking rails version 4.1+ to send in some table create SQL as the "as".
@garysweaver Yeah, I hear you. It's definitely better now than before. You're the one with commit access, so run the project however you want. I'm sure you'd be happy to have a PR with tests, right?
this should have failed anyways but since the rails-4.1 was not "yet" at the method signature change - it did not ...
I might be wrong here thus a test is welcome anyways, keep in mind that they need to be 1.8 syntax and that we run our tests all the way down to 2.3 ... thank you for caring about JRuby on Rails!