New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't barf on the datetime2 data type when connecting to MS SQL 2008 #233
Conversation
Running into this problem. Is there anything blocking this pull? Anything I can do to help? |
I'm also running into this issue. Also this is a duplicate of #116 - are the build failures related to this pull request? What do we need to do to get this moving? A failing test for 2008? |
I guess ms sql doesn't get any love around here? |
taking quite a while, I'll try to manage but it's hard without a MS-SQL DB ... a (specific) tests would be great to make sure it ain't breaking anything else ... could someone add one please (I'm willing to get this up than - assuming no test failures) ? |
@kares - I meant no disrespect. I really appreciate all the hard work you guys are doing!!! I'm more than willing to test MS-SQL DB. The project is making my own life much more enjoyable so I'll be glad to do whatever I can. I met with @nicksieger briefly at Rubyconf in Denver about some ideas I had regarding the MS SQL portion of the code. I'd definitely like to be more involved in that area. |
@kares I'll work on getting a failing test for this issue |
so I do have a MS-SQL but failed to reproduce this so far ... if someone could provide a failing test-case pls otherwise I do not see any reason to merge this since the regex applies for all adapters (known and unknown) not only MS-SQL |
This is certainly causing problems in my rails application. I spent a bit of time this weekend trying to create a failing test, but I wasn't able to replicate it in a unit test. I don't have the code available at the moment. @gregors, what were you seeing? |
OK, yes the problem looks like it still exists - but it's more difficult to see. When creating a table from within rails using a migration the type datetime is created - when using activerecord against an existing database with uses the newer datetime2 type it most definitely fails - for instance I was using activerecord to pump test data into an asp.net MVC application (which suses datetime2) via factorty_girl, boom fail all day long. So I guess a valid test is to manually create a table with datetime2 and watch it blow up? |
I created another test in a pull request, I am not seeing any issues on master |
As #116 was not reproduced probably due some changes on master that fixed the issue, I'm closing this one. |
Still failing in my rail application with 1.2.7, will see if I can make a standalone test. Your bundle is complete! Use
|
Just to confirm that this issue still exists in master, when connecting to Azure SQL Database. The fix in the pull request works for me. Please consider merging. |
Don't barf on the datetime2 data type when connecting to MS SQL 2008