Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update README.md #511

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

chapmajs commented Dec 6, 2013

activerecord-jdbc-adapter dies on versions < 5.0

Update README.md
activerecord-jdbc-adapter dies on versions < 5.0
Owner

kares commented Dec 7, 2013

thanks @chapmajs ... did you consider putting this in the wiki (cause if we'll add details abotu requirements for each adapter we support into the README it might as well get bloated a bit) ? not sure where (for now there's the configuration section and notes on profiling/troubleshooting mysql) - maybe you can setup an adapter requirements page where we can list stuff for each adapter a link it from the README, thanks ...

Contributor

chapmajs commented Dec 9, 2013

This PR changes specifically the README for MySQL with the JDBC. It already talks about the MySQL Connector/J so I figured it was the natural place to put a note about version requirements. I can create a wiki page if that is clearer.

Owner

kares commented Dec 9, 2013

OK, actually that must be smt specific to AR-JDBC ... the driver seems to officially still support 4.1 ... if it's not that big of an issue we can (and should) fix it (please run the tests and/or share the trace - I do not have or plan to setup 4.1), otherwise we shall note that we dropped < 5.0 support ... I think there are some code "quirks" around ArJdbc::MySQL to run on pre 5.0 thus would be great to get back into shape as much as possible.

Contributor

chapmajs commented Dec 9, 2013

It's a hardcoded version test in adapter.rb for AR-JDBC. I have a pull request in for fixing the error it tries to raise, because the error it's currently using isn't present in Rails anymore.

Contributor

chapmajs commented Dec 12, 2013

Just realized that it may not have been entirely clear that the requirement is > 5.0 for the Connector/J driver

Owner

kares commented Dec 13, 2013

oh - I see, we do not need to go into that much detail in the README - feel free to note that on the wiki .
most users use the activerecord-jdbcmysql-adapter gem (where it's handled as a dependency) instead of setting up the driver on the class-path. thx!

@kares kares closed this Dec 13, 2013

@chapmajs chapmajs deleted the chapmajs:patch-1 branch Dec 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment