Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Firebird] Rails 4 Fixes #512

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

rzane commented Dec 8, 2013

Calling visit_Arel_Nodes_SelectCore(x) raised an Argument Error with Rails 4. It looks like this change was made for other adapters with @ce7d68df455c0c5bf246a3ed2a781e6c88725359.

Not-null blob values were inserting null values and failing as described in #430. I basically copied the changes that were made in @47bcdcf866a6c2303d6e64cf83b8441affccf706 for the DB2 adapter.

Firebird can't have the table name in the set clause of an update statement. I added the quote_table_name_for_assignment override used in the SQLite3 adapter. (https://github.com/jruby/activerecord-jdbc-adapter/blob/master/lib/arjdbc/sqlite3/adapter.rb#L226-L228)

Owner

kares commented Dec 11, 2013

Ray, I already added ad137a6 for the other fixes you squashed into one please rebase and open another PR and include a better commit message - just like you did previously ... Thanks!

@kares kares closed this Dec 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment